Remove agent-templates.json after aka.ms link redirect#852
Remove agent-templates.json after aka.ms link redirect#852
Conversation
….ms redirect) Agent-Logs-Url: https://github.com/Azure/awesome-azd/sessions/fee5e3a4-225c-4b72-b661-578fda0d2e28 Co-authored-by: hemarina <104857065+hemarina@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Azure/awesome-azd/sessions/992e5418-e8b2-4b4c-aea1-d99788fd17e8 Co-authored-by: hemarina <104857065+hemarina@users.noreply.github.com>
jongio
left a comment
There was a problem hiding this comment.
CI is failing because agent-templates.test.ts imports ../static/agent-templates.json, which this PR deletes. The test was restored per your earlier comment, but that creates a broken state - the test exists but its data dependency is gone.
Since agent-templates.json isn't referenced by any source code (only by this test), the test file should also be deleted in this PR. The test validates data that won't exist anymore.
Also worth including the aka.ms redirect URL in the PR description so reviewers can verify it's live and pointing to the right place.
…lot/remove-agent-templates-json
There was a problem hiding this comment.
My earlier concern about CI failing (test importing the deleted JSON) is resolved - the merge from main brought in the unification that updated agent-templates.test.ts to read from templates.json with a templateType discriminator instead.
The deletion is now clean:
- CI passes
- No remaining references to
agent-templates.jsonin source or test code - The agent template data lives in
templates.jsonwithtemplateType: "extension.ai.agent"
One note: the PR description still says "Deleted website/static/agent-templates.json" without mentioning the unification that happened on main. Might be worth a one-liner noting that agent templates were migrated into templates.json before this deletion, so future readers understand the sequence.
No blocking issues. Ready for un-drafting when you're satisfied.
|
PR needs to be merged after Azure/azure-dev#7968 |
|
This PR is on hold since users might not be updated to the latest extension version. Will merge this PR after a couple of weeks where no users are using azd-ext-azure-ai-agents_0.1.28-preview |
The
agent-templates.jsonfile was a temporary artifact needed until the aka.ms link redirect was set up. That redirect is now live, so this file is no longer needed.website/static/agent-templates.json