Add template: functions-quickstart-typescript-azd-service-bus (Issue #824)#832
Add template: functions-quickstart-typescript-azd-service-bus (Issue #824)#832
Conversation
- Author: Anthony Chu - Added description from source repo README - Removed inapplicable rag framework - Added servicebus, vnets, managedidentity to azureServices - Removed workflow artifacts (validation_errors.log, validation_result.json) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@manvkaur This PR looks ready. I converted it from draft to ready. Feel free to keep it draft. |
|
@hemarina , I am waiting for PR merge in corresponding azure-samples for some fixes, I will also resolve the templates.json |
There was a problem hiding this comment.
Pull request overview
Adds a new Microsoft-authored azd template entry to the Awesome AZD gallery so it can be discovered and filtered on the website.
Changes:
- Added a new template record for
functions-quickstart-typescript-azd-service-bustowebsite/static/templates.json. - Tagged the template for filtering (msft/new, TypeScript, and relevant Azure services).
| { | ||
| "title": "Azure Functions with Service Bus and VNet (TypeScript)", | ||
| "description": "End-to-end TypeScript sample demonstrating secure triggering of a Flex Consumption function app from a Service Bus instance secured in a virtual network, using managed identity and VNet integration.", | ||
| "preview": "./templates/images/functions-e2e-sb-vnet.png", |
There was a problem hiding this comment.
The referenced preview image ./templates/images/functions-e2e-sb-vnet.png does not appear to exist under website/static/templates/images/, so the gallery will render a broken image. Please add the image file at that path or update preview to point to an existing asset (e.g., ./templates/images/test.png temporarily).
| "preview": "./templates/images/functions-e2e-sb-vnet.png", | |
| "preview": "./templates/images/test.png", |
|
Note: PR on hold until confirmed by @manvkaur |
jongio
left a comment
There was a problem hiding this comment.
Template metadata validates cleanly - all required fields present, tags correctly categorized (functions, servicebus, vnets, managedidentity in azureServices; typescript in languages; bicep in IaC), source repo exists, and preview image is in place.
Deployment proof provided in the PR description - thanks for that.
@manvkaur one thing blocking merge: there are conflicts in templates.json that'll need rebasing once the upstream changes land. Let me know if you need help resolving those.
jongio
left a comment
There was a problem hiding this comment.
Template metadata looks good. All required fields present, tags are correctly categorized (functions, servicebus, vnets, managedidentity in azureServices; typescript in languages; bicep in IaC), source repo exists, and preview image is on main.
Deployment proof provided in the PR description - thanks for including that.
One thing blocking merge: there are conflicts in templates.json that'll need rebasing once the upstream azure-samples changes land. @manvkaur let me know if you need help resolving those.
Closes #824
If you are submitting a new
azdtemplate to the galleryYour template repository
https://github.com/Azure-Samples/functions-quickstart-typescript-azd-service-bus
Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/static/templates.json that includes:
Azure Functions with Service Bus and VNet (TypeScript)t./templates/images/functions-e2e-sb-vnet.pngmsft,newtypescriptfunctions,servicebus,vnets,managedidentity24281657-9ae3-4aa3-9dfb-b832f69f408fRequired tags:
msft)bicep)newtag for any newly authored templatesIn the PR comment, if you can also add a link to the PR where you made your repo
azdcompatible this will allow us to provide feedback on your template and speed up the review process.If the template is Microsoft-authored, we encourage you to also publish it to learn.microsoft.com/samples.
Deployment Proof:
Additional validations:
Function app is up and running (deployment involved additional function - timer trigger not in template which sends sb message to auto invoke sb trigger inside vnet)
Service Bus Trigger Function is invoked -
This PR was created manually after the automated workflow failed to create it due to insufficient permissions. Template submission from issue #824.