Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

[PWGCF] Added histograms for efficiency as a function of eta pt and centrality#16914

Merged
SwatiSaha-1997 merged 31 commits into
AliceO2Group:masterfrom
nidamalikk:master
Jul 4, 2026
Merged

[PWGCF] Added histograms for efficiency as a function of eta pt and centrality#16914
SwatiSaha-1997 merged 31 commits into
AliceO2Group:masterfrom
nidamalikk:master

Conversation

@nidamalikk

Copy link
Copy Markdown
Contributor

No description provided.

@nidamalikk nidamalikk requested a review from alibuild as a code owner July 3, 2026 12:04
@github-actions github-actions Bot added the pwgcf label Jul 3, 2026
@github-actions github-actions Bot changed the title Added histograms for efficiency as a function of eta pt and centrality [PWGCF] Added histograms for efficiency as a function of eta pt and centrality Jul 3, 2026
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild

alibuild commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 89e0f9f at 2026-07-03 14:17:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 2 errors and 10 warnings.'
Found 2 errors and 10 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/da6906e92d44ffa5e1cb62164991f0ae4c50b854/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:450:23: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:451:23: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
++ [[ 10 -gt 0 ]]
++ cat /sw/BUILD/da6906e92d44ffa5e1cb62164991f0ae4c50b854/O2Physics-code-check/warnings.txt
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1291:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1293:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1295:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1297:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1299:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1301:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1303:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1305:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1307:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1309:32: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

@nidamalikk

Copy link
Copy Markdown
Contributor Author

@lauraser Dear Laura, can you please merge it into master as well?

@SwatiSaha-1997 SwatiSaha-1997 merged commit 52a6fba into AliceO2Group:master Jul 4, 2026
15 of 16 checks passed
@vkucera

vkucera commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

@nidamalikk This PR does not add any histograms.

@nidamalikk

Copy link
Copy Markdown
Contributor Author

@vkucera Sorry for the misinformation.

In the PR just before this one, I added histograms for efficiency correction that also depend on centrality. However, due to an error in how I defined the CCDB histogram, it produced incorrect values. After noticing the mistake, I fixed it. In this PR, I only changed the histogram type from TH2D to TH2F. As this PR is related to the previous one, that's why I put the same title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

5 participants