[PWGDQ] clang-tidy bug fixes in tableMaker(MC)_withAssoc

[mcoquet642]

No description provided.

[github-actions]

O2 linter results: ❌ 125 errors, ⚠️ 47 warnings, 🔕 0 disabled

[alibuild]

Error while checking build/O2Physics/code-check for 033b88c at 2026-07-03 13:11:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 44 errors and 0 warnings.'
Found 44 errors and 0 warnings.
++ [[ 44 -gt 0 ]]
++ cat /sw/BUILD/182661ef1038aa3358baa51117a2ef9a288e55ba/O2Physics-code-check/errors.txt
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:498:30: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:515:29: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:732:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:735:8: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:766:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:769:8: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:779:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:782:8: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:883:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:902:14: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1169:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1498:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1502:10: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1563:67: error: narrowing conversion from 'double' to 'Int_t' (aka 'int') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1696:10: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1699:6: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:95:7: error: variable 'zorro' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:583:30: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:600:29: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:690:67: error: narrowing conversion from 'double' to 'Int_t' (aka 'int') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:902:12: error: variable 'tvxRate' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1021:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1023:14: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1025:16: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1027:18: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1030:18: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1033:18: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1036:18: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1048:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1051:8: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1133:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1136:8: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1142:50: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1142:103: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1148:84: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1164:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1167:8: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1326:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1345:14: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1382:10: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1384:10: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1596:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

[alibuild]

Error while checking build/O2Physics/o2 for 0108fc4 at 2026-07-03 18:30:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/TableProducer/tableMaker_withAssoc.cxx:696:21: error: comparison of integer expressions of different signedness: 'int' and 'std::array<const char*, 5>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
ninja: build stopped: subcommand failed.

Full log here.

[alibuild]

Error while checking build/O2Physics/staging for 0108fc4 at 2026-07-03 18:36:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/TableProducer/tableMaker_withAssoc.cxx:696:21: error: comparison of integer expressions of different signedness: 'int' and 'std::array<const char*, 5>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
ninja: build stopped: subcommand failed.

Full log here.

[alibuild]

Error while checking build/O2Physics/code-check for 0108fc4 at 2026-07-03 18:57:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 43 errors and 0 warnings.'
Found 43 errors and 0 warnings.
++ [[ 43 -gt 0 ]]
++ cat /sw/BUILD/a122d91a2267bdb698a3eac9a92a1ffddb8aa66c/O2Physics-code-check/errors.txt
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:497:30: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:514:29: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:731:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:734:8: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:765:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:768:8: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:778:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:781:8: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:882:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:901:14: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1168:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1497:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1501:10: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1562:67: error: narrowing conversion from 'double' to 'Int_t' (aka 'int') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1695:10: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1698:6: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:95:7: error: variable 'zorro' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:600:29: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:690:67: error: narrowing conversion from 'double' to 'Int_t' (aka 'int') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:696:21: error: comparison of integers of different signs: 'int' and 'size_type' (aka 'unsigned long') [clang-diagnostic-sign-compare,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:902:12: error: variable 'tvxRate' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1023:14: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1025:16: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1027:18: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1030:18: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1033:18: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1036:18: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1048:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1051:8: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1133:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1136:8: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1142:50: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1142:103: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1148:84: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1164:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1167:8: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1326:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1345:14: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1382:10: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1384:10: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1596:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:2047:10: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
[0 more errors; see full log]

Full log here.