feat(agent): add push_notification to inject messages during multi-turn prompts#1858
Open
lazytanuki wants to merge 1 commit into
Open
feat(agent): add push_notification to inject messages during multi-turn prompts#1858lazytanuki wants to merge 1 commit into
push_notification to inject messages during multi-turn prompts#1858lazytanuki wants to merge 1 commit into
Conversation
…turn prompts Add a `pending_notifications` field to `Agent` that acts as a per-conversation message queue, and a `push_notification` method to enqueue messages from outside the prompt loop. The queued messages are consumed as `User` messages at the start of each loop iteration in both the non-streaming and streaming prompt paths, allowing external events (e.g. a background task or signal from a tool) to inject new input mid-conversation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
This PR adds a
push_notificationmethod toAgentthat allows injecting user messages into an already-running multi-turn prompt, similar to how OpenCode makes it possible to send input to an active agent mid-conversation.How it works
Agent::push_notification(conversation_id, message)enqueues a message into a per-conversation pending queue.Usermessages into the conversation history.Arc<Mutex<...>>, so cloning the agent shares the same queue, enabling cross-task patterns like spawning a background watcher that callspush_notificationwhen an external event occurs.Example
Disclosure
Thanks!