Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

Commit d180293

Browse files
fix: Disable Breaking change related code site (#731)
* fix: a race condition in test * . * . * . * . * . * . * . * . * . * . * . * . Co-authored-by: Stephanie Wang <stephaniewang526@users.noreply.github.com>
1 parent 08bff34 commit d180293

3 files changed

Lines changed: 12 additions & 12 deletions

File tree

google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriter.java

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -485,16 +485,17 @@ private void onFailure(Throwable t) {
485485
private void onSuccess(AppendRowsResponse response) {
486486
for (int i = 0; i < inflightRequests.size(); i++) {
487487
AppendRowsResponse.Builder singleResponse = response.toBuilder();
488-
if (offsetList.get(i) > 0) {
489-
// singleResponse.setOffset(offsetList.get(i));
490-
} else {
491-
long actualOffset = response.getOffset();
492-
for (int j = 0; j < i; j++) {
493-
actualOffset +=
494-
inflightRequests.get(j).message.getProtoRows().getRows().getSerializedRowsCount();
495-
}
496-
// singleResponse.setOffset(actualOffset);
497-
}
488+
// if (offsetList.get(i) > 0) {
489+
// singleResponse.setOffset(offsetList.get(i));
490+
// } else {
491+
// long actualOffset = response.getOffset();
492+
// for (int j = 0; j < i; j++) {
493+
// actualOffset +=
494+
//
495+
// inflightRequests.get(j).message.getProtoRows().getRows().getSerializedRowsCount();
496+
// }
497+
// singleResponse.setOffset(actualOffset);
498+
// }
498499
inflightRequests.get(i).appendResult.set(singleResponse.build());
499500
}
500501
}

google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriterTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -908,10 +908,8 @@ public void testFlushAll() throws Exception {
908908
ApiFuture<AppendRowsResponse> appendFuture1 = sendTestMessage(writer, new String[] {"A"});
909909
ApiFuture<AppendRowsResponse> appendFuture2 = sendTestMessage(writer, new String[] {"B"});
910910
ApiFuture<AppendRowsResponse> appendFuture3 = sendTestMessage(writer, new String[] {"C"});
911-
912911
assertFalse(appendFuture3.isDone());
913912
writer.flushAll(100000);
914-
915913
assertTrue(appendFuture3.isDone());
916914

917915
writer.close();

google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta2/it/ITBigQueryWriteManualClientTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,7 @@ public void testJsonStreamWriterBatchWriteWithCommittedStream()
257257

258258
ApiFuture<AppendRowsResponse> response =
259259
jsonStreamWriter.append(row, -1, /* allowUnknownFields */ false);
260+
260261
// Temp for Breaking Change.
261262
response.get();
262263
// assertEquals(0, response.get().getOffset());

0 commit comments

Comments
 (0)