From dd693007fe284cc61dfd2cfe02fbc1e1affa25fe Mon Sep 17 00:00:00 2001 From: Robert Dailey Date: Thu, 6 Aug 2015 17:17:32 -0500 Subject: [PATCH 1/3] Remove user-declared constructors for response class Removed the following defaulted constructors: * Default Constructor * Copy Constructor * Move Constructor The defaulted move constructor prevents implicit declaration of the copy assignment operator, which results in compiler errors since std::promise requires it. All 3 user-declared methods removed here are implicitly declared by the compiler anyway, so no need to default them in the first place. Relates to #547 --- http/src/network/http/v2/client/response.hpp | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/http/src/network/http/v2/client/response.hpp b/http/src/network/http/v2/client/response.hpp index 21cf37c0c..37fa348f9 100644 --- a/http/src/network/http/v2/client/response.hpp +++ b/http/src/network/http/v2/client/response.hpp @@ -60,23 +60,6 @@ class response { */ typedef headers_type::const_iterator const_headers_iterator; - /** - * \brief Constructor. - */ - response() = default; - - /** - * \brief Copy constructor. - * \param other The other response object. - */ - response(const response &other) = default; - - /** - * \brief Move constructor. - * \param other The other response object. - */ - response(response &&other) noexcept = default; - /** * \brief Swap function. * \param other The other response object. From a89ad1c58f75bd3bc6c64ef12953d2f8aa499071 Mon Sep 17 00:00:00 2001 From: Eisenberger Tamas Date: Sun, 20 Sep 2015 09:17:50 +0200 Subject: [PATCH 2/3] Fix generating doc when source path includes space(s) --- Doxyfile.in | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/Doxyfile.in b/Doxyfile.in index 44ad4bc51..e83ca1ea4 100644 --- a/Doxyfile.in +++ b/Doxyfile.in @@ -128,10 +128,10 @@ FULL_PATH_NAMES = YES # If left blank the directory from which doxygen is run is used as the # path to strip. -STRIP_FROM_PATH = @CMAKE_CURRENT_SOURCE_DIR@/error/src/ \ - @CMAKE_CURRENT_SOURCE_DIR@/uri/src/ \ - @CMAKE_CURRENT_SOURCE_DIR@/http/src/ \ - @CMAKE_CURRENT_SOURCE_DIR@/concurrency/src/ +STRIP_FROM_PATH = "@CMAKE_CURRENT_SOURCE_DIR@/error/src/" \ + "@CMAKE_CURRENT_SOURCE_DIR@/uri/src/" \ + "@CMAKE_CURRENT_SOURCE_DIR@/http/src/" \ + "@CMAKE_CURRENT_SOURCE_DIR@/concurrency/src/" # The STRIP_FROM_INC_PATH tag can be used to strip a user-defined part of # the path mentioned in the documentation of a class, which tells @@ -651,10 +651,10 @@ WARN_LOGFILE = # directories like "/usr/src/myproject". Separate the files or directories # with spaces. -INPUT = @CMAKE_CURRENT_SOURCE_DIR@/error/ \ - @CMAKE_CURRENT_SOURCE_DIR@/uri/src/network/ \ - @CMAKE_CURRENT_SOURCE_DIR@/http/src/network/http/ \ - @CMAKE_CURRENT_SOURCE_DIR@/concurrency/src/network/ +INPUT = "@CMAKE_CURRENT_SOURCE_DIR@/error/" \ + "@CMAKE_CURRENT_SOURCE_DIR@/uri/src/network/" \ + "@CMAKE_CURRENT_SOURCE_DIR@/http/src/network/http/" \ + "@CMAKE_CURRENT_SOURCE_DIR@/concurrency/src/network/" # This tag can be used to specify the character encoding of the source files # that doxygen parses. Internally doxygen uses the UTF-8 encoding, which is @@ -686,7 +686,7 @@ RECURSIVE = YES # Note that relative paths are relative to the directory from which doxygen is # run. -EXCLUDE = @CMAKE_CURRENT_SOURCE_DIR@/uri/src/network/uri/detail +EXCLUDE = "@CMAKE_CURRENT_SOURCE_DIR@/uri/src/network/uri/detail" # The EXCLUDE_SYMLINKS tag can be used to select whether or not files or # directories that are symbolic links (a Unix file system feature) are excluded @@ -849,10 +849,10 @@ COLS_IN_ALPHA_INDEX = 5 # The IGNORE_PREFIX tag can be used to specify one or more prefixes that # should be ignored while generating the index headers. -IGNORE_PREFIX = @CMAKE_CURRENT_SOURCE_DIR@/error/src/ \ - @CMAKE_CURRENT_SOURCE_DIR@/uri/src/ \ - @CMAKE_CURRENT_SOURCE_DIR@/http/src/ \ - @CMAKE_CURRENT_SOURCE_DIR@/concurrency/src/ +IGNORE_PREFIX = "@CMAKE_CURRENT_SOURCE_DIR@/error/src/" \ + "@CMAKE_CURRENT_SOURCE_DIR@/uri/src/" \ + "@CMAKE_CURRENT_SOURCE_DIR@/http/src/" \ + "@CMAKE_CURRENT_SOURCE_DIR@/concurrency/src/" #--------------------------------------------------------------------------- # configuration options related to the HTML output From 84119e5b68ecc9653660c7913cc5d4edf3645f27 Mon Sep 17 00:00:00 2001 From: Glyn Matthews Date: Wed, 30 Sep 2015 13:21:55 +0200 Subject: [PATCH 3/3] Testing travis notifications in slack. --- .travis.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.travis.yml b/.travis.yml index a4c995187..57288ef4f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -36,3 +36,8 @@ script: - cmake -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} -DBUILD_SHARED_LIBS=${BUILD_SHARED_LIBS} -DCPP-NETLIB_DISABLE_LIBCXX=YES -DCPP-NETLIB_DISABLE_FEATURE_TESTS=YES .. - make - make test + +notifications: + slack: + rooms: + - cpp-netlib:NRR34vWovC6yqLXYn0rb0xDp#travis