Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: react/yoga
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: react/yoga
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: release-v3.0
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 18 commits
  • 22 files changed
  • 7 contributors

Commits on Feb 23, 2024

  1. Update Yoga.podspec: fixes archiving for Mac Catalyst

    Summary:
    Hi
    
    When I tried to archive macos catalyst app in Xcode I got errors:
    
    <img width="977" alt="Screenshot 2024-02-05 at 00 03 32" src="https://github.com/kesha-antonov/react-native/assets/11584712/b83f75a5-b42f-42e4-9afa-1e2527501baa">
    
    This PR fixes archiving by linking PrivateHeaders in yoga.framework
    
    <img width="399" alt="Screenshot 2024-02-05 at 01 03 48" src="https://github.com/kesha-antonov/react-native/assets/11584712/089080ad-b1dc-4703-9273-d8aa3253205e">
    
    <img width="1404" alt="Screenshot 2024-02-05 at 01 05 18" src="https://github.com/kesha-antonov/react-native/assets/11584712/5263cb80-8a53-4a51-bcfc-9d3a2ba739b4">
    
    Prev PR here react/react-native#42159
    
    ## Changelog:
    
    [IOS] [FIXED] - fixed archiving for Mac Catalyst
    
    X-link: react/react-native#42847
    
    Reviewed By: NickGerleman
    
    Differential Revision: D53920474
    
    Pulled By: cipolleschi
    
    fbshipit-source-id: 0534d9aa9d249e4e0c35ada0464c38c291be7f84
    kesha-antonov authored and NickGerleman committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    efbebb4 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Fix MacCatalyst archiving for stand-alone pod (#1585)

    Summary:
    Pull Request resolved: #1585
    
    When used alone, yoga has no visibility over the USE_FRAMEWORKS variable set by React Native.
    
    In this case, there is no other way to know whether the current target that will install the spec is using use_framewors or not. As a failsafe, condition, let's always add the `"$(PODS_TARGET_SRCROOT)"` to the search paths to make sure that archiving won't fail.
    
    Whe used in other context, that should not be a problem: search paths are just directory Xcode uses to find headers that are needed.
    
    Reviewed By: NickGerleman
    
    Differential Revision: D54417386
    
    fbshipit-source-id: aa2ae41c077e4346c0417c73291a37c992a06b58
    cipolleschi authored and NickGerleman committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    59fb251 View commit details
    Browse the repository at this point in the history
  2. Set version to 3.0.0

    NickGerleman committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    fe7dc21 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Configuration menu
    Copy the full SHA
    749b6b2 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Reduce warning level of distributed Yoga builds (#1592)

    Summary:
    X-link: react/react-native#43405
    Pull Request resolved: #1592
    
    Fixes #1590
    
    Yoga may be built with a high warning level. This is helpful in letting Yoga be used in more places, and finding defects. We currently set these in the internal BUCK build, the CMake reference build, and the Yoga Standalone (not RN) CocoaPods build.
    
    Yoga's reference CMake build and spec are consumed today by users of Yoga, instead of just Yoga developers. Here, it makes more sense to avoid anything that could break compiler-to-compiler compatibility.
    
    We default these to a less intense (`-Wall -Werror`). I kept `/W4`, for pragmatic reasons, and since it is relatively standard for MSVC.
    
    We continue to build with strict flags on Buck build on Clang.
    
    Reviewed By: cortinico
    
    Differential Revision: D54735661
    
    fbshipit-source-id: 130e35ac9dcffa2f7e70e48d18770f1275864e2a
    NickGerleman committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    508b9a5 View commit details
    Browse the repository at this point in the history
  2. Fix bug where absolute nodes were not insetted correctly in certain c…

    …ases (#1593)
    
    Summary:
    Pull Request resolved: #1593
    
    X-link: react/react-native#43417
    
    There was a bug where we did not position absolute nodes correctly if the static node had a different main/cross axis from the containing node. This fixes that. The change is somewhat complicated unfortunately but I tried to add sufficient comments to explain what is happening
    
    Reviewed By: NickGerleman
    
    Differential Revision: D54703955
    
    fbshipit-source-id: 096c643f61d4f9bb3ee6278d675ebd69b57350d7
    joevilches authored and NickGerleman committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    e82479e View commit details
    Browse the repository at this point in the history
  3. Fixup npm package README

    Summary: Remove some outdated information and make sure that npmjs shows the builtin TypeScript typings (now that we no longer have clever resolution schemes).
    
    Reviewed By: javache
    
    Differential Revision: D54788636
    
    fbshipit-source-id: 76e7663924189fd68ac62b27730f44213b13ad85
    NickGerleman committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    75e564d View commit details
    Browse the repository at this point in the history
  4. Set version to 3.0.1

    NickGerleman committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    1745019 View commit details
    Browse the repository at this point in the history
  5. typings -> types

    NickGerleman committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    95cf065 View commit details
    Browse the repository at this point in the history
  6. Set version to 3.0.2

    NickGerleman committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    397d304 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Bump README

    NickGerleman committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    5b106e5 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Entry point without TLA for js package (#1638)

    Summary:
    Follow up on #1637
    
    TLDR: tooling for TLA is not there yet; An additional entry point without top-level-await is appropriate
    
    - adds ./load entry to js package
    - uses .js file extensions to prevent requiring [allowImportingTsExtensions](https://www.typescriptlang.org/tsconfig#allowImportingTsExtensions)
    
    Pull Request resolved: #1638
    
    Reviewed By: joevilches
    
    Differential Revision: D55614636
    
    Pulled By: NickGerleman
    
    fbshipit-source-id: 126a94aa68d22d32b938282cfa1a5059bb9df337
    bbohlender authored and NickGerleman committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    334eebc View commit details
    Browse the repository at this point in the history
  2. Add JavaScript bindings for YGHasNewLayout (#1631)

    Summary:
    Adds JavaScript bindings for YGHasNewLayout which introduces
    two new node methods: `hasNewLayout()` and `markLayoutSeen()`.
    
    Closes #681
    
    Pull Request resolved: #1631
    
    Reviewed By: joevilches
    
    Differential Revision: D55213296
    
    Pulled By: NickGerleman
    
    fbshipit-source-id: 161288c3f54c2b82a6b2b842387916fe8713c2c9
    WillsonHaw authored and NickGerleman committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    8a9758a View commit details
    Browse the repository at this point in the history
  3. Set version to 3.0.3

    NickGerleman committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    ed5d2ff View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Isolate Distributed JavaScript (#1645)

    Summary:
    Pull Request resolved: #1645
    
    Right now we publish Yoga by transforming in-place, and rewriting the entrypoint to point to the generated vanilla JavaScript.
    
    It is nice to include the original source, e.g. so that users can use sourcemaps when debugging, but putting these files on top of each other has been causing problems, like #1637 (comment)
    
    This changes the packaging step to instead put all the outputs into a "dist" folder, and point the package entrypoints there. We still include original source for sourcemap usage.
    
    Reviewed By: yungsters
    
    Differential Revision: D56093470
    
    fbshipit-source-id: ecd52dddd9040294aae66747cf1fdf48c7f602e7
    NickGerleman committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    29f016c View commit details
    Browse the repository at this point in the history
  2. Don't run test validation off main branch (#1644)

    Summary:
    Pull Request resolved: #1644
    
    Because Chrome behaviors can change
    
    Reviewed By: cortinico
    
    Differential Revision: D56088135
    
    fbshipit-source-id: 7f760786dde061df9af034368e2184117e6e6846
    NickGerleman committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    866f503 View commit details
    Browse the repository at this point in the history
  3. Set version to 3.0.4

    NickGerleman committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    1b9b878 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Fix JS build on Windows (#1648)

    Summary:
    Pull Request resolved: #1648
    
    Node made a breaking change in a security release for 18/20 where `spawn()` no longer loads `.bat` files by default. nodejs/node@69ffc6d. Execute command in shell.
    
    Reviewed By: javache
    
    Differential Revision: D56230965
    
    fbshipit-source-id: 52e9bd8a76664bd07ea25b6355ac54fcb24cbb9a
    NickGerleman committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    af57b21 View commit details
    Browse the repository at this point in the history
Loading