Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

Commit 3d66ea4

Browse files
committed
[design] add version name
1 parent 7cde7b8 commit 3d66ea4

5 files changed

Lines changed: 25 additions & 12 deletions

File tree

src/index.html

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1296,11 +1296,18 @@ <h1 class="menu-item-header-text">Clear</h1>
12961296
<h1 class="menu-item-header-text">nightTab</h1>
12971297
</div>
12981298
<div class="menu-item-form">
1299-
<p class="p-wrap">Version <strong class="display-version"></strong></p>
1299+
<div class="p-wrap">
1300+
<p class="mb-1">Version <strong class="display-version"></strong></p>
1301+
<p class="display-name small mb-0"></p>
1302+
</div>
13001303
<hr>
1301-
<p class="p-wrap">Project repository on <a href="https://github.com/zombieFox/nightTab" class="a-underline" target="_blank" tabindex="-1">Github.</a></p>
1304+
<div class="p-wrap">
1305+
<p>Project repository on <a href="https://github.com/zombieFox/nightTab" class="a-underline" target="_blank" tabindex="-1">Github.</a></p>
1306+
</div>
13021307
<hr>
1303-
<p class="p-wrap">For feedback and support, submit an <a href="https://github.com/zombieFox/nightTab/issues" class="a-underline" target="_blank" tabindex="-1">Issues.</a></p>
1308+
<div class="p-wrap">
1309+
<p>For feedback and support, submit an <a href="https://github.com/zombieFox/nightTab/issues" class="a-underline" target="_blank" tabindex="-1">Issues.</a></p>
1310+
</div>
13041311
</div>
13051312
</div>
13061313
</div>

src/js/data.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,12 +53,12 @@ var data = (function() {
5353

5454
mod.restore = function(data) {
5555
if (data) {
56-
if (!("version" in data) || data.version != version.get()) {
56+
if (!("version" in data) || data.version != version.get().number) {
5757
console.log("data version " + data.version + " found less than current");
5858
data = update.run(data);
5959
mod.set(_saveName, JSON.stringify(data));
6060
} else {
61-
console.log("data version " + version.get() + " no need to run update");
61+
console.log("data version " + version.get().number + " no need to run update");
6262
mod.set(_saveName, JSON.stringify(data));
6363
};
6464
} else {
@@ -233,7 +233,7 @@ var data = (function() {
233233
var save = function() {
234234
mod.set(_saveName, JSON.stringify({
235235
nighttab: true,
236-
version: version.get(),
236+
version: version.get().number,
237237
state: state.get(),
238238
bookmarks: bookmarks.get()
239239
}));

src/js/init.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// log version
2-
console.log("nightTab version", version.get());
2+
console.log("nightTab version", version.get().number, "(" + version.get().name + ")");
33
data.init();
44
state.init();
55
bookmarks.init();

src/js/update.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -665,9 +665,9 @@ var update = (function() {
665665
};
666666

667667
// if no update is needed version bump
668-
if (version.compare(data.version, version.get()) == -1) {
669-
console.log("\t > nothing to update, version bump to", version.get());
670-
data.version = version.get();
668+
if (version.compare(data.version, version.get().number) == -1) {
669+
console.log("\t > nothing to update, version bump to", version.get().number);
670+
data.version = version.get().number;
671671
};
672672

673673
return data;

src/js/version.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ var version = (function() {
22

33
var current = "4.0.0";
44

5+
var name = "Enchanting Aardvark";
6+
57
var compare = function(a, b) {
68
var pa = a.split(".");
79
var pb = b.split(".");
@@ -26,11 +28,15 @@ var version = (function() {
2628

2729
var get = function() {
2830
// return chrome.runtime.getManifest().version;
29-
return current;
31+
return {
32+
number: current,
33+
name: name
34+
};
3035
};
3136

3237
var render = function() {
33-
helper.e(".display-version").textContent = get();
38+
helper.e(".display-version").textContent = get().number;
39+
helper.e(".display-name").textContent = get().name;
3440
};
3541

3642
var init = function() {

0 commit comments

Comments
 (0)