Lokasi ngalangkungan proxy:   [ UP ]  
[Ngawartoskeun bug]   [Panyetelan cookie]                
Skip to content

Commit 646a324

Browse files
committed
review feedback
1 parent 7927ffb commit 646a324

29 files changed

Lines changed: 116 additions & 99 deletions

docs/tools/sql-database-projects/concepts/package-references.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ The following example includes a package reference to the `Contoso.AdventureWork
4141

4242
### System databases
4343

44-
The SQL system databases (`master`, `msdb`) are been published on NuGet.org as database reference packages. These packages contain the schema for the system databases and can be used as package references in SQL projects. The system database packages are versioned to align with the version of SQL Server they're associated with. For example, the `master` system database package for SQL Server 2022 is `Microsoft.SqlServer.Dacpacs.Master` version `160.2.1` and can be added to a SQL project as a package reference:
44+
The SQL system databases (`master`, `msdb`) are published on NuGet.org as database reference packages. These packages contain the schema for the system databases and can be used as package references in SQL projects. The system database packages are versioned to align with the version of SQL Server they're associated with. For example, the `master` system database package for SQL Server 2022 is `Microsoft.SqlServer.Dacpacs.Master` version `160.2.1` and can be added to a SQL project as a package reference:
4545

4646
```xml
4747
...

docs/tools/sql-database-projects/concepts/pre-post-deployment-scripts.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,4 +91,4 @@ This script `scripts\before-script.sql` is executed before the deployment plan i
9191

9292
- [SqlPackage Publish parameters, properties, and SQLCMD variables](../../sqlpackage/sqlpackage-publish.md)
9393
- [SQLCMD variables overview](sqlcmd-variables.md)
94-
- [Tutorial: Create and deploy a SQL project](../tutorials/creating-and-deploying-a-sql-project.md)
94+
- [Tutorial: Create and deploy a SQL project](../tutorials/create-deploy-sql-project.md)

docs/tools/sql-database-projects/concepts/schema-comparison.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ The differences between source and target appear in a grid for easy review. Comp
4141
- SQL database project
4242
- `.dacpac` file
4343

44-
In schema compare you can drill into and review each difference in the results grid or in script form where line by line details of the changes are available. You can also selectively exclude specific differences before updating the target. The schema compare tooling is available in Visual Studio, Azure Data Studio, and the command line.
44+
In schema compare you can drill into and review each difference in the results grid or in script form where details of the changes are available at a per-line level. You can also selectively exclude specific differences before updating the target. The schema compare tooling is available in Visual Studio, Azure Data Studio, and the command line.
4545

4646
### Schema comparison options
4747

@@ -57,7 +57,7 @@ The object types that are included in the comparison can also be configured. The
5757

5858
### Schema compare files
5959

60-
The comparison definition for schema compare can be saved as an `.scmp` file. This file stores information about the schema comparison in XML and includes:
60+
The comparison definition for schema compare can be saved as an `.scmp` file, known as a *schema compare file*. This file stores information about the schema comparison in XML and includes:
6161

6262
- source and target connection information
6363
- comparison options
@@ -99,7 +99,7 @@ An `.scmp` file can be opened in Visual Studio or Azure Data Studio to easily ru
9999

100100
To change the grouping preference, select the **Group Results** dropdown list in the toolbar. Select **Type** to group the results by object type (for example, by tables, views, or stored procedures).
101101

102-
7. By default all differences are included in the scope of the Update Target action. You can exclude differences that you don't want to synchronize. To do so, uncheck the **Action** column in the center of each row. Alternatively, right-click a row in the Schema pane, and select **Exclude**. The row is immediately grayed out. When it's time to update the target database, this row isn't considered for any pending changes.
102+
7. By default all differences are included in the scope of the Update Target action. You can exclude differences that you don't want to synchronize. To do so, uncheck the **Action** column in the center of each row. Alternatively, right-click a row in the Schema pane, and select **Exclude**. The row is immediately grayed out. When schema compare is used to update the target database, this row isn't considered for any pending changes.
103103

104104
You can also right-click on a group row and select **Exclude All** or **Include All**, which is equivalent to unchecking or checking all differences in that group. When you group results by schema this is a useful way to include or exclude all changes to a specific schema.
105105

@@ -144,7 +144,7 @@ To update the schema of the target, you have two options. You can update the tar
144144

145145
:::image type="content" source="media/schema-comparison/ads-schema-compare.png" alt-text="Screenshot of Schema comparison interface in Azure Data Studio comparing a database against a project." lightbox="media/schema-comparison/ads-schema-compare.png":::
146146

147-
5. By default all differences are included in the scope of the Update Target action. You can exclude differences that you don't want to synchronize. To do so, uncheck the **Action** column in the center of each row. Alternatively, right-click a row in the Schema pane, and select **Exclude**. The row is immediately grayed out. When it's time to update the target database, this row isn't considered for any pending changes.
147+
5. By default all differences are included in the scope of the Update Target action. You can exclude differences that you don't want to synchronize. To do so, uncheck the **Action** column in the center of each row. Alternatively, right-click a row in the Schema pane, and select **Exclude**. The row is immediately grayed out. When schema compare is used to update the target database, this row isn't considered for any pending changes.
148148

149149
You can also right-click on a group row and select **Exclude All** or **Include All**, which is equivalent to unchecking or checking all differences in that group. When you group results by schema this is a useful way to include or exclude all changes to a specific schema.
150150

@@ -164,6 +164,6 @@ To update the schema of the target, you have two options. You can update the tar
164164

165165
## Related content
166166

167-
- [Compare a database and a project](../howto/compare-a-database-and-a-project.md)
168-
- [Tutorial: start from an existing database](../tutorials/start-from-an-existing-database.md)
167+
- [Compare a database and a project](../howto/compare-database-project.md)
168+
- [Tutorial: start from an existing database](../tutorials/start-from-existing-database.md)
169169
- [SqlServer.Dac.Compare namespace](/dotnet/api/microsoft.sqlserver.dac.compare)

docs/tools/sql-database-projects/concepts/sql-code-analysis/sql-code-analysis.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ zone_pivot_groups: sq1-sql-projects-tools
1414

1515
[!INCLUDE [SQL Server Azure SQL Database Azure SQL Managed Instance](../../../../includes/applies-to-version/sql-asdb-asdbmi.md)]
1616

17-
You can eliminate potential design and naming problems and avoid performance pitfalls by analyzing your database code. The concepts are very similar to performing static analysis to detect and correct defects in managed code. You configure which analysis rules you want to apply to your database code, analyze the code, and then correct or ignore the issues that you identify. Before you can analyze your database code, you must first import your database schema into a database project. For more information, see [Start from an existing database](../../tutorials/start-from-an-existing-database.md).
17+
You can eliminate potential design and naming problems and avoid performance pitfalls by analyzing your database code. The concepts are very similar to performing static analysis to detect and correct defects in managed code. You configure which analysis rules you want to apply to your database code, analyze the code, and then correct or ignore the issues that you identify. Before you can analyze your database code, you must first import your database schema into a database project. For more information, see [Start from an existing database](../../tutorials/start-from-existing-database.md).
1818

1919
By performing static analysis with the [provided rules](#provided-rules), you can identify problems that fall into the following categories:
2020

@@ -48,7 +48,7 @@ A SQL project file can contain two properties, `RunSqlCodeAnalysis` and `SqlCode
4848
...
4949
```
5050

51-
The `SqlCodeAnalysisRules` element specifies the rules and their error/warning behavior. In the following example the rules Microsoft.Rules.Data.SR0006 and Microsoft.Rules.Data.SR0007 are disabled and the a detection for the rule Microsoft.Rules.Data.SR0008 will result in a build error.
51+
The `SqlCodeAnalysisRules` element specifies the rules and their error/warning behavior. In the following example the rules Microsoft.Rules.Data.SR0006 and Microsoft.Rules.Data.SR0007 are disabled and a detection for the rule Microsoft.Rules.Data.SR0008 will result in a build error.
5252

5353
```xml
5454
<?xml version="1.0" encoding="utf-8"?>

docs/tools/sql-database-projects/concepts/sql-projects-extensibility.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,6 @@ Deployment contributors are reusable through parameterization and can be used in
3939
## Related content
4040

4141
- [Extending the Database Features](../../../ssdt/extending-the-database-features.md)
42-
- [Tutorial: Create and deploy a SQL project](../tutorials/creating-and-deploying-a-sql-project.md)
42+
- [Tutorial: Create and deploy a SQL project](../tutorials/create-deploy-sql-project.md)
4343
- [SqlPackage Publish parameters, properties, and SQLCMD variables](../../sqlpackage/sqlpackage-publish.md)
4444
- [Code analysis rules extensibility overview](code-analysis-extensibility.md)

docs/tools/sql-database-projects/concepts/sqlcmd-variables.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,5 +105,5 @@ SqlPackage /Action:Publish /SourceFile:AdventureWorks.dacpac /TargetConnectionSt
105105
## Related content
106106

107107
- [SqlPackage Publish parameters, properties, and SQLCMD variables](../../sqlpackage/sqlpackage-publish.md)
108-
- [Tutorial: Create and deploy a SQL project](../tutorials/creating-and-deploying-a-sql-project.md)
108+
- [Tutorial: Create and deploy a SQL project](../tutorials/create-deploy-sql-project.md)
109109
- [Database Project Settings](../../../ssdt/database-project-settings.md)

docs/tools/sql-database-projects/concepts/target-platform.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,5 +85,5 @@ When publishing a SQL project, the target platform of the project must match the
8585
## Related content
8686

8787
- [SqlPackage Publish parameters, properties, and SQLCMD variables](../../sqlpackage/sqlpackage-publish.md)
88-
- [Tutorial: Create and deploy a SQL project](../tutorials/creating-and-deploying-a-sql-project.md)
88+
- [Tutorial: Create and deploy a SQL project](../tutorials/create-deploy-sql-project.md)
8989
- [Database Project Settings](../../../ssdt/database-project-settings.md)

docs/tools/sql-database-projects/getting-started.md renamed to docs/tools/sql-database-projects/get-started.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ dotnet new install Microsoft.Build.Sql.Templates
6565
6666
## Create a new project
6767

68-
We start our project by creating a new SQL database project before manually adding objects to it. There are other ways to create a project that enable immediately populating the project with objects from an existing database, such as using the [schema comparison tools](howto/compare-a-database-and-a-project.md).
68+
We start our project by creating a new SQL database project before manually adding objects to it. There are other ways to create a project that enable immediately populating the project with objects from an existing database, such as using the [schema comparison tools](howto/compare-database-project.md).
6969

7070
::: zone pivot="sq1-visual-studio"
7171

@@ -247,6 +247,6 @@ sqlpackage /Action:Publish /SourceFile:bin/Debug/projectname.dacpac /TargetConne
247247

248248
## Related content
249249

250-
- [Compare a database and a project](howto/compare-a-database-and-a-project.md)
251-
- [Convert an original SQL project to an SDK-style project](howto/convert-an-original-sql-project.md)
250+
- [Compare a database and a project](howto/compare-database-project.md)
251+
- [Convert an original SQL project to an SDK-style project](howto/convert-original-sql-project.md)
252252
- [Analyze T-SQL code to find defects](howto/analyze-t-sql-code-to-find-defects.md)

docs/tools/sql-database-projects/howto/analyze-t-sql-code-to-find-defects.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ For this initial assessment, you want to find all the potential problems in the
2020

2121
## Prerequisites
2222

23-
Before you can analyze the code in a database project, you must already have a SQL project. For more information on using an existing database to create a project, see [Tutorial: start from an existing database](../tutorials/start-from-an-existing-database.md).
23+
Before you can analyze the code in a database project, you must already have a SQL project. For more information on using an existing database to create a project, see [Tutorial: start from an existing database](../tutorials/start-from-existing-database.md).
2424

2525
## Enable SQL code analysis on project build
2626

0 commit comments

Comments
 (0)